가격 버튼의 버그를 수정합니다. #267
Merged
가격 버튼의 버그를 수정합니다. #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- width 증가 - PriceButton에서도 설정 추가
- GestureState 사용 시, 취소 종료 실패했을 때 자동으로 false - 즉 두 손가락 터치로 제스처가 취소되면 false로 자동 복구
snughnu
requested review from
dongglehada,
sunjae0902 and
tomchoi95
and removed request for
dongglehada
tomchoi95
approved these changes
Feb 3, 2026
dongglehada
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
작업 내용 및 고민 내용
1. 가격 표시 한 줄 고정
.fixedSize()를 적용하여 본래 크기 유지.fixedSize() + .drawingGroup()으로 묶어 하나의 렌더링 단위로 처리.minimumScaleFactor(0.7)+.lineLimit(1)로 전체가 함께 축소되도록 구현ItemRow의 가격 버튼 width를 89pt에서 95pt로 증가2. 두 손가락 터치 시 UI 멈춤 문제 해결
onEnded가 호출되지 않아isPressed = true상태로 고정@State→@GestureState로 변경.onChanged + .onEnded방식 →.updating방식으로 변경@GestureState는 제스처가 취소/종료/실패 시 자동으로 초기값(false)으로 리셋되므로, 두 손가락 터치로 제스처가 취소되어도 자동으로press상태가 해제됨을 이용스크린샷
리뷰 요구사항