-
Notifications
You must be signed in to change notification settings - Fork 0
[#304] CameraPreview에서 리모트 기기의 연결 끊김을 감지하지 못하는 문제를 해결한다. #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
da4b6fd
refactor: Browser의 AsyncStream을 BrowserStreamManager로 분리
YunDaeHyeon 0a4e01e
refactor: BrowsingManager 분리
YunDaeHyeon 511fab0
refactor: BrowserCommand 분리
YunDaeHyeon f0cd586
feat: HeartBeat Continuation private로 변경
YunDaeHyeon 2343a8c
refactor: Browser 내부 enum Command 분리
YunDaeHyeon a93ce98
chore: 폴더 이름 BrowserManager -> Manager로 변경
YunDaeHyeon cc8b457
fix: CameraPreview에서 리모트 기기 끊김 대응
sangYuLv 690f152
fix: 촬영 모드 알리는 시점 수정
sangYuLv 234a3e0
fix: 워치에서 x 버튼 눌렀을 때 연결 해제 요청 전송
sangYuLv ef91d20
fix: 촬영 기기에서 워치에서 보낸 연결 해제 요청 반응
sangYuLv 47b2b39
fix: 타이머 모드 상태 browser에서 기록 -> 늦게 전달 받는 상황 해결
sangYuLv 6a0dde0
style: 필요 없는 로직 제거
sangYuLv 914846b
refactor: 리모트 버튼 화면의 백버튼 제거
sangYuLv 7202145
style: 사용하지 않는 속성 제거
sangYuLv b1eb8ea
fix: 타임아웃 시 모든 연결 해제
sangYuLv d3ffbcf
fix: 병합 충돌 해결
sangYuLv 94b8b8f
fix: 깃헙 빌드 오류 해결 (main actor)
sangYuLv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,5 +28,6 @@ struct RemoteCaptureView: View { | |
| } | ||
| } | ||
| } | ||
| .navigationBarBackButtonHidden() | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
꼭 분리할 필요가 있었을까? 라는 생각을 했지만
메서드 이름이
handleDisconnection이니 오히려 직관적으로 다가와서 좋은 것 같네요 👀