Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http::parser reports basic_fields errors #2920

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Aug 17, 2024

No description provided.

@ashtum ashtum force-pushed the parser_reports_basic_fields_errors branch 2 times, most recently from 4d66b54 to 0040621 Compare August 17, 2024 13:44
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 98.98990% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.12%. Comparing base (848e206) to head (e306445).
Report is 6 commits behind head on develop.

Files Patch % Lines
include/boost/beast/http/impl/basic_parser.ipp 98.24% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2920      +/-   ##
===========================================
+ Coverage    93.07%   93.12%   +0.05%     
===========================================
  Files          177      177              
  Lines        13709    13643      -66     
===========================================
- Hits         12759    12705      -54     
+ Misses         950      938      -12     
Files Coverage Δ
include/boost/beast/http/basic_parser.hpp 94.11% <ø> (ø)
include/boost/beast/http/detail/basic_parser.hpp 100.00% <ø> (ø)
include/boost/beast/http/detail/basic_parser.ipp 88.30% <ø> (-0.44%) ⬇️
include/boost/beast/http/fields.hpp 100.00% <ø> (ø)
include/boost/beast/http/impl/error.ipp 95.83% <100.00%> (+0.18%) ⬆️
include/boost/beast/http/impl/fields.hpp 97.56% <100.00%> (+0.48%) ⬆️
include/boost/beast/http/parser.hpp 86.95% <100.00%> (ø)
include/boost/beast/http/impl/basic_parser.ipp 97.12% <98.24%> (+1.67%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848e206...e306445. Read the comment docs.

@ashtum ashtum force-pushed the parser_reports_basic_fields_errors branch 3 times, most recently from 5ee6333 to 66ef339 Compare August 20, 2024 13:22
@ashtum ashtum force-pushed the parser_reports_basic_fields_errors branch from 66ef339 to 653d778 Compare August 20, 2024 14:40
@ashtum ashtum force-pushed the parser_reports_basic_fields_errors branch from 653d778 to 470525a Compare August 20, 2024 16:15
@ashtum ashtum force-pushed the parser_reports_basic_fields_errors branch 2 times, most recently from cc1a751 to 2f21264 Compare August 20, 2024 20:18
@ashtum ashtum force-pushed the parser_reports_basic_fields_errors branch from 2f21264 to cd772b7 Compare August 21, 2024 07:50
@ashtum ashtum merged commit aefc564 into boostorg:develop Aug 21, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants