Use the dynamic type while calling epsilon(). #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current call to epsilon is made with the assumption that the dynamic type `content_type` is compatible with double. This does not hold true for numeric types that are bigger than double, e.g: `absl::uint128`. This CL fixes it by binding the call to `content_type`'s type.
barendgehrels
approved these changes
Sep 16, 2025
|
Made a mistake with the author email used to commit in the other PR. The current PR uses the correct email with my employer domain. |
tinko92
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
This looks good to me. epsilon for some custom integer type will be zero, so same behaviour as comparing to ~1e-16. It requires any content_type to have a numeric_limits specialisation but the header already requires that anyway.
This comparison to an unscaled epsilon looks dubious in general, but that's unrelated to the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current call to epsilon is made with the assumption that the dynamic type
content_typeis compatible with double. This does not hold true for numeric types that are bigger than double, e.g:absl::uint128. This CL fixes it by binding the call tocontent_type's type.This fixes #1430.