Skip to content

Commit

Permalink
Fix node 20 issue on GHA CI (#758)
Browse files Browse the repository at this point in the history
* Update containers
  • Loading branch information
Flamefire authored Dec 8, 2024
1 parent e5f5bce commit eb142a3
Showing 1 changed file with 16 additions and 6 deletions.
22 changes: 16 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ on:
env:
LIBRARY: gil
UBSAN_OPTIONS: print_stacktrace=1
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

jobs:
posix:
defaults:
run:
shell: bash
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -84,19 +86,27 @@ jobs:
os: ubuntu-20.04
- toolset: clang
cxxstd: "14,17"
os: macos-12
os: macos-13

runs-on: ${{matrix.os}}
container: ${{matrix.container}}
container:
image: ${{matrix.container}}
volumes:
- /node20217:/node20217:rw,rshared
- ${{ startsWith(matrix.container, 'ubuntu:1') && '/node20217:/__e/node20:ro,rshared' || ' ' }}

steps:
- uses: actions/checkout@v3

- name: Setup container environment
if: matrix.container
run: |
apt-get -y update
apt-get -y install sudo python3 git g++
apt-get -y install sudo python3 git g++ curl
if [[ "${{matrix.container}}" == "ubuntu:1"* ]]; then
# Node 20 doesn't work with Ubuntu 16/18 glibc: https://github.com/actions/checkout/issues/1590
curl -sL https://archives.boost.io/misc/node/node-v20.9.0-linux-x64-glibc-217.tar.xz | tar -xJ --strip-components 1 -C /node20217
fi
- uses: actions/checkout@v4

- name: Install packages
if: matrix.install
Expand Down

0 comments on commit eb142a3

Please sign in to comment.