Add support for modular build structure. #233
Conversation
…a source in install targets.
|
General FYI.. I'm doing changes to the PR to account for your feedback (and all the other feedback in other PRs). Again, thanks for taking a careful look. Much appreciated! |
…ction logic. Put back missing check and config rules.
|
Please review and merge this PR at your earliest convenience. |
config/build.jam
Outdated
| # Copyright René Ferdinand Rivera Morell | ||
| # Distributed under the Boost Software License, Version 1.0. | ||
| # (See accompanying file LICENSE_1_0.txt or copy at | ||
| # http://www.boost.org/LICENSE_1_0.txt) | ||
|
|
||
| import-search /boost/predef/tools ; | ||
| import predef ; | ||
|
|
||
| project | ||
| : requirements | ||
| # Set these to computed values according to the build. | ||
| [ predef.address-model ] | ||
| [ predef.architecture ] | ||
| ; |
There was a problem hiding this comment.
What is the purpose of this file? Is it actually needed?
There was a problem hiding this comment.
It sets the address-model and architecture features to the platform detected values for all the config subprojects. Which is what allows this https://github.com/boostorg/log/pull/233/files#diff-b200e03281a7c4df9a1bfad85a764447a1a56954a2efc88f8ba8c212acb38686R18 to be just fetching the feature value.
There was a problem hiding this comment.
I thought you said these properties are auto-detected and always set now, are they not?
Config projects are used from the main build Jamfile, are these (and all other) properties not forwarded to the config projects when they are compiled? I think, they need to be.
This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.
This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:
This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.