-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constexpr conversion to MPL types #134
base: develop
Are you sure you want to change the base?
Constexpr conversion to MPL types #134
Conversation
43e9ab4
to
7c23e86
Compare
7c23e86
to
17d9fd9
Compare
17d9fd9
to
edf42d5
Compare
As noted in #133 I'm rather inclined to treat this as a non-bug, or at least one that can't be fixed without breaking stuff. The problem with this fix is it means that code that relies on this conversion, and on mpl::bool_ being at least forward declared after including a type_traits header will be broken (and will need to be modified to include the mpl headers explicitly, as you did for the test case, which quite deliberately did not do that). I realise they should be doing that already, but if we're forcing folks to change their code, it would be better to mark this interface as deprecated, and suggest they dispatch on integral_constant instead. |
Ok, I just will create a new duplicate test that and will not touch this to show that nothing should be broken by this change. |
Stop, why we should support the code that uses mpl types and not including mpl? Is not it a bug in their code? |
It is, in my opinion, a bug in their code; and the answer to your question is probably "because code in unmaintained libraries will break and we'll need to fix it." :-) |
If the only concerns are about Boosts code, I volunteer myself to identify and fix them. |
I made a list of libraries with |
Fixes #133
GCC, Clang, MSVC, ICC, all of them are fine with this https://godbolt.org/z/6K6NDm