Use more decimals for Pi in angle conversions #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous value had twelve signficant digits which is quite below the maximum precision of double floating numbers. In this change the value returned by Python for the expression math.pi * 2 is used. This value is the same returned by std::cos(-1) * 2 with 16 significant digits.
|
I didn't try running the tests because the set up doesn't look straight forward and the tolerances used for comparison in test_trig.cpp are rather large. I didn't find any mention of degree or gradian elsewhere in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous value had twelve signficant digits which is quite below the maximum precision of double floating numbers.
In this change the value returned by Python for the expression math.pi * 2 is used. This value is the same as the one returned by std::cos(-1) * 2 with 16 significant digits.