Skip to content

Conversation

@alandefreitas
Copy link
Member

All view types in Boost.URL have iterators that store raw pointers to external data rather than references to the view object itself. This means iterators remain valid even after the view is destroyed.

fix #927

@cppalliance-bot
Copy link

cppalliance-bot commented Jan 23, 2026

An automated preview of the documentation is available at https://966.url.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-01-23 23:04:58 UTC

@cppalliance-bot
Copy link

cppalliance-bot commented Jan 23, 2026

GCOVR code coverage report https://966.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://966.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff Report (in development) https://966.url.prtest2.cppalliance.org/diff-report/index.html

Build time: 2026-01-23 23:15:14 UTC

All view types in Boost.URL have iterators that store raw pointers
to external data rather than references to the view object itself.
This means iterators remain valid even after the view is destroyed,
satisfying the borrowed_range requirements.

Specializations added for:
- decode_view, pct_string_view
- params_view, params_ref, params_encoded_view, params_encoded_ref
- segments_view, segments_ref, segments_encoded_view, segments_encoded_ref

fix boostorg#927
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.35%. Comparing base (4c6d357) to head (e7325b2).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #966   +/-   ##
========================================
  Coverage    99.35%   99.35%           
========================================
  Files          161      161           
  Lines         8771     8771           
========================================
  Hits          8714     8714           
  Misses          57       57           
Files with missing lines Coverage Δ
include/boost/url/decode_view.hpp 100.00% <ø> (ø)
include/boost/url/params_encoded_ref.hpp 100.00% <ø> (ø)
include/boost/url/params_ref.hpp 100.00% <ø> (ø)
include/boost/url/params_view.hpp 100.00% <ø> (ø)
include/boost/url/pct_string_view.hpp 100.00% <ø> (ø)
include/boost/url/segments_encoded_ref.hpp 100.00% <ø> (ø)
include/boost/url/segments_ref.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6d357...e7325b2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alandefreitas alandefreitas merged commit 14fb347 into boostorg:develop Jan 26, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

specialize std::ranges::enable_borrowed_range for C++20?

2 participants