[ADHOC] chore(evm): set up deploy logic for LimitedSignerValidator #404
Conversation
🦋 Changeset detectedLatest commit: f040e96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
topocount
changed the title
|
1 similar comment
|
There was a problem hiding this comment.
I added the broadcasts @topocount You want me to do the SDK changes in this PR or spin up a second one for that part?
| `LimitedSignerValidator` hard caps the claim quantity for a given incentive | ||
| regardless of the validity of individual action requests presented to the signer. | ||
|
|
||
| Most incentives hard-cap each address to one claim, but `ERC20PeggedVariableCriteriaIncentive` |
There was a problem hiding this comment.
I believe there are other incentives that don't hard-cap this, may be worth checking and adding.
|
@Quazia Let's do those in a second PR. The SDK class exists for this, but it'd be good to add it as a default where necessary. |
|
packages/evm/README.md
Outdated
| does not, by design. | ||
| and `ERC20VariableIncentive` do not, by design. `ERC1155Incentive` catalogs | ||
| individual claims by transaction hash, as opposed to claimant. |
There was a problem hiding this comment.
@Quazia I went through the incentives and called out all that don't track claim target.
|
@topocount Yeah it's plugging in the defaults specifically that I wanted to handle. I'll get that going right now |
This PR deploys LimitedSignerValidator for use as a part of the protocol.
This will hard-cap all incentive claims, regardless of how many valid actions
the claimant submits.
Testing
Ensured that this deployment works on private forks of Base mainnet and also sepolia