ephemeral: Fix execute unit #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one was subtle...at some point we moved over to Rust raw strings `r#` where we no longer needed `\\`. The next bug here is we were missing `After=`. The semantics of a plain `Requires=` without `After=` are very weak and systemd basically skipped over the missing device. Closes: bootc-dev#139 Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a subtle bug in the systemd unit generation by adding the necessary After= directive to complement the existing Requires=, ensuring the correct service execution order. The change also fixes an incorrect backslash escape sequence within a raw string. The changes are concise and effective. I've added a couple of suggestions to improve maintainability by extracting repeated string literals into variables, which will make future modifications easier and less error-prone.
ckyrouac
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was subtle...at some point we moved over to Rust raw strings
r#where we no longer needed\\. The next bug here is we were missingAfter=.The semantics of a plain
Requires=withoutAfter=are very weak and systemd basically skipped over the missing device.Closes: #139