Makefile: Remove build dependency from install target#2019
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Feb 25, 2026
Merged
Makefile: Remove build dependency from install target#2019cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively decouples the build and install steps in the Makefile by introducing a new all target for building and removing the build dependency from the install target. This is a good change that follows standard Makefile practices and solves the issue of unintended rebuilds in different environments. The addition of checks in the install target to ensure build artifacts exist is also a great improvement for user experience. I have one suggestion to make the completion artifact check more robust.
cgwalters
force-pushed
the
completion-fix
branch
from
4c741bc to
36e1b98
Compare
The Makefile's CARGO_FEATURES auto-detection based on /usr/lib/os-release can produce different results in the install environment vs build environment. This causes 'make install' to rebuild the binary without the intended features (e.g., rhsm). Pass CARGO_FEATURES explicitly to ensure the install step doesn't trigger an unwanted rebuild with different features. Assisted-by: OpenCode (Claude Opus 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
completion-fix
branch
from
36e1b98 to
460632a
Compare
Collaborator
Author
|
Already trying this downstream in https://gitlab.com/redhat/centos-stream/rpms/bootc/-/merge_requests/81 |
henrywang
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile's CARGO_FEATURES auto-detection based on /usr/lib/os-release
can produce different results in the install environment vs build
environment. This causes 'make install' to rebuild the binary without
the intended features (e.g., rhsm).
Pass CARGO_FEATURES explicitly to ensure the install step doesn't
trigger an unwanted rebuild with different features.