fix: add optional flag that allows skipping npm audit checks with OWASP dependency-check scanner #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Allow users to skip npm auditing via flag.
Description
This allows skipping npm audit checks. The core error returned for us (needing us to add this flag to optionally skip this test):
This can be tested independently. This is mainly because tests can fail because of possible bugs upstream with the OWASP dependency checker itself (it appears to be brittle/flaky/unknown in why it tends to error):
https://github.com/search?q=repo%3Ajeremylong%2FDependencyCheck+Could+not+perform+Node+Audit+analysis.+Invalid+payload+submitted+to+Node+Audit+API&type=issues
They vary from duplicated dependencies (which npm may allow, but the npm audit may not, which owasp does not honor by avoiding deduplication) to simply unknown/major version releases.
How Has This Been Tested
This was tested manually in a jenkins setup with @ltdonner-bah's review.
Types of Changes
Checklist