Merged
Conversation
The `cargo playdate run` examples in the README referred to `sp-simple`. However, while the actual file is called `sp-simple.rs`, the example is called just `sp`. Hence, correct the README with the right name.
When running locally, the `cargo run`/`cargo playdate run` examples in the README failed to compile due to missing required features. Hence, add the relevant flag to all examples to ensure that they build and run correctly, assuming the rest of the pre-requisites have been met.
Contributor
Author
|
I think your work on making Rust a viable option for Playdate development is awesome, and I wanted to help out 😄 I only just pulled the repo and noticed that the examples in the README didn't quite work, hence me making this request. Please let me know if you have any thoughts or suggestions. I hope that once I become more familiar, I would be able to contribute more to your project (only if you are ok with that, of course). Thanks again for putting in the work to make this! |
boozook
approved these changes
Sep 7, 2024
Owner
|
Thank you very much, great find! ❤️🔥
That could be awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request covers some minor improvements to the README. These consist of:
playdate-soundexample to use the actual example name,sp, instead of the source file name,sp-simple