Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log file link should not be in "about" view #1862

Closed
ThomasWaldmann opened this issue Nov 30, 2023 · 15 comments
Closed

log file link should not be in "about" view #1862

ThomasWaldmann opened this issue Nov 30, 2023 · 15 comments
Assignees
Labels
good first issue Simple change to start learning code base type:enhancement Improvement of an existing function

Comments

@ThomasWaldmann
Copy link
Collaborator

ThomasWaldmann commented Nov 30, 2023

Description

"Click here to view the logs" was put into the "About" dialogue (in between some web links there).

It should really be in "Schedule" -> "Log", just below the formatted summary - so one can look into the full log if that summary does not offer enough information (which is quite frequently the case).

Environment

  • Vorta version: 0.9.1.beta3 but also older versions

Note: a good related ticket is #1838, can be solved before or after this one.

@real-yfprojects
Copy link
Collaborator

I guess, there should be a link at both places.

@real-yfprojects real-yfprojects added type:enhancement Improvement of an existing function good first issue Simple change to start learning code base labels Dec 8, 2023
@SAMAD101
Copy link
Collaborator

image

Where exactly? There is no good place to put that link.

@ThomasWaldmann
Copy link
Collaborator Author

Above that table, there could be:

"If you see a non-zero returncode, please check the log files for more details."

"log files" linking to the folder with the vorta log files.

@pavankalyan767
Copy link

is this issue still open can i work on this ?

@ThomasWaldmann
Copy link
Collaborator Author

@SAMAD101 are you still working on this?

@SAMAD101
Copy link
Collaborator

SAMAD101 commented Jan 9, 2024

@SAMAD101 are you still working on this?

No, I'm working on another issue.

@ThomasWaldmann
Copy link
Collaborator Author

@pavankalyan224847 you have it!

@m3nu
Copy link
Contributor

m3nu commented Jan 9, 2024

Yes, makes sense to implement this.

I'll release 0.9 soon with all the changes from GSoC. Let's add this before.

@pavankalyan767
Copy link

pavankalyan767 commented Jan 10, 2024

@ThomasWaldmann logs should be removed from "About" view and the link should be added in the "Log" view in schedule but above the table containing Time,category,subcommand,return code right ? and one more thing can you please tell me the folders in which code related to about view and table are written

@ThomasWaldmann
Copy link
Collaborator Author

Yes.

You should be able to find the source files by searching for some english text strings you see in the related views on the vorta UI.

@pavankalyan767
Copy link

I have made changes in my local repo but i am not able to see changes when in run vorta using that branch ex : i have removed the logs from about view and updated my main branch and then i run vorta using that branch but i can still see logs in the about view can you please tell me how i can check changes that i have made in my main branch

@ThomasWaldmann
Copy link
Collaborator Author

@pavankalyan224847 it might be helpful if you open a PR with what you have and ask that there.

@pavankalyan767
Copy link

ohk then i'll create a PR

@shivansh02
Copy link
Collaborator

Can I work on this since author of #1909 is busy at the moment?

@pavankalyan767
Copy link

yes sure go ahead you can refer to my commits on the PR which may be helpfull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple change to start learning code base type:enhancement Improvement of an existing function
Projects
None yet
Development

No branches or pull requests

6 participants