Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loglink removed from about and added to Logs #1909

Closed
wants to merge 1 commit into from
Closed

loglink removed from about and added to Logs #1909

wants to merge 1 commit into from

Conversation

pavankalyan767
Copy link

@pavankalyan767 pavankalyan767 commented Jan 26, 2024

removed the click to vew logs link from about view and added it to Logs

#1862

Copy link
Author

@pavankalyan767 pavankalyan767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have personally reviewed my changes please review the PR and let me know if any changes have to be made to the PR thank you .

@m3nu
Copy link
Contributor

m3nu commented Jan 30, 2024

Thanks. I'll run your changes locally and let you know if they are good to merge. Thanks and sorry for the delay.

@pavankalyan767
Copy link
Author

pavankalyan767 commented Jan 30, 2024

That's totally alright Thank you for looking into it and please guide me through other issues that i can work on

@pavankalyan767
Copy link
Author

Please tell me if the work on this issue is complete so that i can start working on other issues thank you

@m3nu
Copy link
Contributor

m3nu commented Feb 3, 2024

Just ran this locally. I think the PR does what it aimed for. What I'd change:

  • Put the text below the table of repo events. Since it's less important than the table.
  • Slightly change text to something like "See here for complete logs". Otherwise the difference between the event table and those logs won't be clear. We could even say "See here for full Borg and Vorta logs" to make it clear output from both is logged there.

Screenshot 2024-02-03 at 16 15 23

@pavankalyan767
Copy link
Author

pavankalyan767 commented Feb 4, 2024

Do you want me to add the above changes ? I would be glad make the above changes through a commit and I have a doubt the changes that i have made on my local machine in the feature branch(the one that i pushed for this PR) I am not able to see any changes on my local machine when i run vorta so I was relying only on Qt creator inorder to make this PR so can you please tell me how I can run these changes locally so that it would speed up my work and the vorta version that is displayed when i run vorta is 0.8.3 thank you

@m3nu
Copy link
Contributor

m3nu commented Feb 4, 2024

Yes, please add the changes and add a new commit here.

For details on how to make code changes, see here: https://vorta.borgbase.com/contributing/

@pavankalyan767
Copy link
Author

pavankalyan767 commented Feb 4, 2024

Yes I'll start working on the new commit , but as you can see i have deleted vorta and then set it up on my local machine by following all the steps mentioned in it and then i have made the changes which i made in this commit and then i run vorta but no changes that i have made are shown please tell me how i can solve this
Screenshot from 2024-02-04 17-00-28

@real-yfprojects
Copy link
Collaborator

Try to use the dev mode vorta --dev.

@pavankalyan767
Copy link
Author

Thank you so much it works

@real-yfprojects
Copy link
Collaborator

  • Put the text below the table of repo events. Since it's less important than the table.

  • Slightly change text to something like "See here for complete logs". Otherwise the difference between the event table and those logs won't be clear. We could even say "See here for full Borg and Vorta logs" to make it clear output from both is logged there.

Did you already manage to implement those changes? @pavankalyan224847

@pavankalyan767
Copy link
Author

pavankalyan767 commented Feb 14, 2024

no not yet i wasn't able to work on it due to my schedule(college exams) i will make a commit but if this issue requires an immediate fix then i would be glad if anyone interested picks it up and makes the necessary changes
Thank you

@real-yfprojects
Copy link
Collaborator

no not yet i wasn't able to work on it due to my schedule(college exams) i will make a commit but if this issue requires an immediate fix

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants