-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loglink removed from about and added to Logs #1909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have personally reviewed my changes please review the PR and let me know if any changes have to be made to the PR thank you .
Thanks. I'll run your changes locally and let you know if they are good to merge. Thanks and sorry for the delay. |
That's totally alright Thank you for looking into it and please guide me through other issues that i can work on |
Please tell me if the work on this issue is complete so that i can start working on other issues thank you |
Just ran this locally. I think the PR does what it aimed for. What I'd change:
|
Do you want me to add the above changes ? I would be glad make the above changes through a commit and I have a doubt the changes that i have made on my local machine in the feature branch(the one that i pushed for this PR) I am not able to see any changes on my local machine when i run vorta so I was relying only on Qt creator inorder to make this PR so can you please tell me how I can run these changes locally so that it would speed up my work and the vorta version that is displayed when i run vorta is 0.8.3 thank you |
Yes, please add the changes and add a new commit here. For details on how to make code changes, see here: https://vorta.borgbase.com/contributing/ |
Try to use the dev mode |
Thank you so much it works |
Did you already manage to implement those changes? @pavankalyan224847 |
no not yet i wasn't able to work on it due to my schedule(college exams) i will make a commit but if this issue requires an immediate fix then i would be glad if anyone interested picks it up and makes the necessary changes |
No worries. |
removed the click to vew logs link from about view and added it to Logs
#1862