PR: tests/unit/test_utils: Parametrize and increase test coverage
#1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtedde
changed the title
bigtedde
changed the title
tests/unit/test_utils: Parametrize and increase test coverage
m3nu
reviewed
Aug 16, 2023
tests/unit/test_utils.py
Outdated
|
|
||
|
|
||
| def test_normalize_path(): | ||
| # Test that path is normalized for macOS, but does nothing for other platforms. |
There was a problem hiding this comment.
How about using normal docstrings to document the function (not lines within a function). That's what's used for other newer Vorta code. E.g.
def blah_func():
"""
Lorem ipsum...
"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible to reduce code duplication in the utils unit tests by using parametrization. Additionally, there are a some utils functions that still needed testing. In this PR, I aim to solve both of these issues.
Related Issue
#1754
Motivation and Context
One of my Google Summer of Code projects involves cleaning up the Vorta tests, reducing duplicated code, and increasing code coverage.
How Has This Been Tested?
Tests work locally by running
pytest, and they pass the GitHub CI checks.Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.