Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: tests/unit/test_diff: increase test coverage #1770

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

bigtedde
Copy link
Collaborator

@bigtedde bigtedde commented Aug 7, 2023

Description

There are some areas of opportunity in the diff_result module for increased test coverage of some class methods and functions. The test_diff module is already well parametrized and does not have a notable amount of code duplication, so here I would like to focus mainly on increasing code coverage.

Related Issue

#1754

Motivation and Context

One of my Google Summer of Code projects involves cleaning up the Vorta tests, reducing duplicated code, and increasing code coverage.

How Has This Been Tested?

Tests work locally by running pytest, and they pass the GitHub CI checks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

tests/unit/test_diff.py Outdated Show resolved Hide resolved
@bigtedde bigtedde changed the title diff unit tests: increase test coverage PR: tests/unit/test_diff: increase test coverage Aug 9, 2023
@bigtedde bigtedde marked this pull request as ready for review August 10, 2023 22:40
@m3nu m3nu merged commit e85ec38 into borgbase:master Aug 17, 2023
36 checks passed
@bigtedde bigtedde deleted the diff_tests branch August 17, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants