fix CHECK_EQUAL #1921
Merged
fix CHECK_EQUAL #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dellaert tagging for visibility. Can confirm this was an issue that this PR fixes. |
|
Wait a minute :-) this is expected behavior: CHECK exits immediately, EXPECT continues, no? |
|
oh yeah, that's true. previously CHECK_EQUAL would return upon success which is never right. my version isn't right either. ha ha, apparently Michael Feathers noticed the same thing: |
|
see #1923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CHECK_EQUAL returned upon success, skipping the rest of the test. :-)