Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ring struct in a separate file #1922

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Ring struct in a separate file #1922

merged 2 commits into from
Dec 9, 2024

Conversation

varunagrawal
Copy link
Collaborator

Moved the Ring struct to a separate file so we can use a common implementation across the board.

This will help in the refactor to reduce code duplication and allow common base class methods.

@varunagrawal varunagrawal added the enhancement Improvement to GTSAM label Dec 8, 2024
@varunagrawal varunagrawal requested a review from dellaert December 8, 2024 16:46
@varunagrawal varunagrawal self-assigned this Dec 8, 2024
dellaert
dellaert approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@varunagrawal varunagrawal merged commit 11142b0 into develop Dec 9, 2024
33 checks passed
@varunagrawal varunagrawal deleted the ring branch December 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
enhancement Improvement to GTSAM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert