Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some issues in the
TableFactor
while debugging an incorrect assignment on conversion fromDiscreteConditional
toTableFactor
. The fixes are listed below.equals
method so it also checks the keys are the same. Updated a unit test to show this.I am also working on improving the conversion from
DecisionTreeFactor
toTableFactor
in a way that should be faster and more memory-efficient than the current scheme. I'll probably push that to the next PR.