-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better SE(3) and SE2(3) Jacobians #1938
Conversation
Tentative approval but that unit test being killed is bothering me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better that we stop and think about the nearZero
throughly. As I mentioned in #1233, we have to be very careful in these approximations.
for example, the expression for D here has a 1000x error when theta is small.
@ProfFan I agree we have to look into it - and that issue is amazing - but I'd rather have a separate PR to deal with the nonZero thresholds. I will add the more thorough tests in this PR, but would like to merge after that. I will add a citation to Ethan Eade's document as I am using his A,B,C constants now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool cool
PS, why did you say "The cutoff should be 1 × 10−3 to use the Taylor expansion" for A? And, I don't understand what you are plotting, actually... |
Implements ExpmapTranslation with SO3::applyLeftJacobian and simplifies the Expmap jacobians in a way that also provides insight in how they relate to the applyLeftJacobian Jacobians. The key piece of code is this:
This does three things:
Smaller things: