Skip to content

Discrete Improvements #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 2, 2025
Merged

Discrete Improvements #1947

merged 5 commits into from
Jan 2, 2025

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Dec 25, 2024 •
edited
Loading

  1. Undid changes to TableFactor::toDecisionTreeFactor since it is giving an incorrect result for a hybrid elimination case with 30+ discrete variables.
  2. Renamed normalization to denominator.
  3. Pass in discrete conditional directly instead of re-converting it.

@varunagrawal varunagrawal self-assigned this Dec 25, 2024
@varunagrawal
Copy link
Collaborator Author

@dellaert reminder

dellaert
dellaert approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve modulo discussion on “normalizer”.

@varunagrawal varunagrawal merged commit 6c516cc into develop Jan 2, 2025
33 checks passed
@varunagrawal varunagrawal deleted the discrete-improvements branch January 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert