Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Timing #1948

Merged
merged 138 commits into from
Jan 8, 2025
Merged

Hybrid Timing #1948

merged 138 commits into from
Jan 8, 2025

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Dec 27, 2024

Add machinery for timing and generating CSVs of runtimes for various hybrid functions and classes.

@varunagrawal
Copy link
Collaborator Author

TBB based environments are failing because of a race condition.

@varunagrawal varunagrawal marked this pull request as ready for review December 31, 2024 15:40
gtsam/base/timing.cpp Outdated Show resolved Hide resolved
gtsam/base/timing.cpp Show resolved Hide resolved
gtsam/base/timing.cpp Outdated Show resolved Hide resolved
gtsam/base/timing.h Outdated Show resolved Hide resolved
gtsam/discrete/DiscreteFactorGraph.cpp Outdated Show resolved Hide resolved
gtsam/hybrid/HybridGaussianISAM.cpp Show resolved Hide resolved
@dellaert
Copy link
Member

dellaert commented Jan 4, 2025

Oh, I think I remember what you meant to do: everything goes into timing and then we merge all changes at the same time?

@varunagrawal
Copy link
Collaborator Author

Oh, I think I remember what you meant to do: everything goes into timing and then we merge all changes at the same time?

Yes that was what I was hoping to do, in case we needed to rollback or fix some things. Once we're happy with the timing of hybrid inference overall, this can be merged. :)

@varunagrawal
Copy link
Collaborator Author

Also you shouldn't have to worry about branch merging when it comes to me. My git-fu is strong. :)

@varunagrawal varunagrawal merged commit 169523e into develop Jan 8, 2025
33 checks passed
@varunagrawal varunagrawal deleted the hybrid-timing branch January 8, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants