Customize discrete elimination in Hybrid #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
reviewed
Dec 31, 2024
dellaert
reviewed
Jan 1, 2025
gtsam/discrete/TableFactor.cpp
Outdated
| @@ -252,6 +252,15 @@ DecisionTreeFactor TableFactor::operator*(const DecisionTreeFactor& f) const { | |||
| DecisionTreeFactor TableFactor::toDecisionTreeFactor() const { | |||
| DiscreteKeys dkeys = discreteKeys(); | |||
|
|
|||
| // If no keys, then return empty DecisionTreeFactor | |||
There was a problem hiding this comment.
Fix in separate PR, with unit test you already have
There was a problem hiding this comment.
Added in #1960
varunagrawal
commented
Jan 2, 2025
dellaert
reviewed
Jan 2, 2025
dellaert
approved these changes
Jan 3, 2025
| * @param factors The factors to multiply as a DiscreteFactorGraph. | ||
| * @return TableFactor | ||
| */ | ||
| static TableFactor TableProduct(const DiscreteFactorGraph &factors) { |
There was a problem hiding this comment.
Can be in another PR, but maybe this should be a method of DiscreteFactorGraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2/3: Customize the elimination of the discrete factors into a conditional on all the discrete variables since they form a fully-connected clique.