Search for K-best solutions #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@varunagrawal review this version? Substantial refactor coming in next PR |
varunagrawal
approved these changes
Jan 28, 2025
| } | ||
| }; | ||
|
|
||
| // Define the Solutions class |
There was a problem hiding this comment.
Maybe more information on why and where this is used so one doesn't have to go hunting through the source code?
|
OK, I will address all these comments in #2006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new class that uses branch-and-bound search to find the K-best solutions quickly. Should be much more efficient than forming the product and enumerating all assignments. Works for both DiscreteBayesNets and DiscreteBayesTrees.
Testing:
Number of expansions: 35 << Asia Bayes net
Number of expansions: 33 << Asia Bayes tree
There were no test failures
real 0m0.027s
user 0m0.006s
sys 0m0.010s