Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial photoswipe widget support #309

Merged
merged 21 commits into from
Jan 25, 2025
Merged

Initial photoswipe widget support #309

merged 21 commits into from
Jan 25, 2025

Conversation

zarya
Copy link
Contributor

@zarya zarya commented Jan 5, 2025

No description provided.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 27 lines in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (371f5b4) to head (1da843b).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/widgets/views.py 15.62% 27 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
- Coverage    83.92%   83.41%   -0.52%     
===========================================
  Files          145      145              
  Lines         4205     4238      +33     
===========================================
+ Hits          3529     3535       +6     
- Misses         676      703      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zarya zarya marked this pull request as ready for review January 5, 2025 20:21
@zarya zarya marked this pull request as draft January 22, 2025 17:54
@zarya zarya marked this pull request as ready for review January 25, 2025 10:58
@zarya zarya force-pushed the photoswipe-widget-0 branch from 7b2013b to c1798bb Compare January 25, 2025 11:21
@@ -1,4 +1,12 @@
<div class="image-hover {{ hoverclass }}">
<i class="fas fa-2x"></i>
<img srcset="{{ url }}{{ url2x }}" src="{{ url }}" height="{{ t.height }}" width="{{ width }}" title="{{ title }}" alt="{{ alt }}" class="img-fluid img-thumbnail">
<div>
<object><a class="attribution-link" href="{{ file.get_absolute_url }}"><span title="{{ file.title }} ({{ file.attribution }})" class="fa-regular fa-arrow-up-right-from-square"></span></a></object>
<object><a class="text-decoration-none license-link" href="{{ file.license_url }}">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* @param {string} license - License name
* @returns {string}
*/
function createLicenseIcon(license) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tykling tykling merged commit 34b8c75 into develop Jan 25, 2025
2 of 4 checks passed
@tykling tykling deleted the photoswipe-widget-0 branch January 25, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants