Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bosch_locator_bridge_utils backward compatibility for galactic #68

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Add bosch_locator_bridge_utils backward compatibility for galactic #68

merged 2 commits into from
Dec 11, 2024

Conversation

kfabian
Copy link
Collaborator

@kfabian kfabian commented Dec 10, 2024

The bosch_locator_bridge_utils still build on galactic if the old tf2 includes are used.

@kfabian
Add bosch_locator_bridge_utils backward compatibility for galactic
258710e 
Signed-off-by: Koenig Fabian (DC/PAR) <fabian.koenig@boschrexroth.de>
@kfabian kfabian requested review from slaible and syyuen December 10, 2024 15:00
slaible
slaible approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@slaible slaible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You could now add to the README that it probably also works for Galactic, analogous to the note for Noetic and Melodic.
(Side node: I think the bigger API change was between Foxy and Galactic, that is why there was never a Foxy version.)

@kfabian
Add hint that humble branch might also work for galactic
d4cedf9 
Signed-off-by: Koenig Fabian (DC/PAR) <fabian.koenig@boschrexroth.de>
@kfabian kfabian merged commit 9f70b18 into humble Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaible slaible slaible approved these changes

@syyuen syyuen Awaiting requested review from syyuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfabian @slaible