Merge bosk-bson back into bosk-mongo #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trying to use bosk-bson outside bosk-mongo, it is very much not as useful as I had thought. The BSON representation is really useful only for MongoDB's specific semantics, where field order is preserved; and, moreover, parsing JSON into BSON is an extraneous step when Jackson already offers a mutable JsonNode representation of JSON. I'll leave it in its own package for now, to make it easier to split out again if we ever have a need to do so. Merging this back before publishing a release us from ending up with a permanent bosk-bson library out in the wild for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to use bosk-bson outside bosk-mongo, it is very much not as useful as I had thought. The BSON representation is really useful only for MongoDB's specific semantics, where field order is preserved; and, moreover, parsing JSON into BSON is an extraneous step when Jackson already offers a mutable JsonNode representation of JSON.
I'll leave it in its own package for now, to make it easier to split out again if we ever have a need to do so.
Merging this back before publishing a release us from ending up with a permanent bosk-bson library out in the wild for now.