Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker client's FIPS endpoint incorrect in us-gov-west-1 #3097

Closed
ben-kaiser opened this issue Jan 12, 2024 · 2 comments
Closed

SageMaker client's FIPS endpoint incorrect in us-gov-west-1 #3097

ben-kaiser opened this issue Jan 12, 2024 · 2 comments
Assignees
Labels
bug This issue is a confirmed bug. p2 This is a standard priority issue

Comments

@ben-kaiser
Copy link

Describe the bug

The Boto3 SageMaker client's endpoint does not match the expected endpoint when setting AWS_USE_FIPS_ENDPOINT=true and AWS_DEFAULT_REGION=us-gov-west-1

Expected Behavior

I expect the endpoint url to match the documented FIPS endpoint

Current Behavior

the endpoint url did not match the documentation:
https://api-fips.sagemaker.us-gov-west-1.amazonaws.com

Reproduction Steps

python@3.9
boto3@1.33.1
botocore@1.33.1

import boto3, os
os.environ["AWS_USE_FIPS_ENDPOINT"]="true"
os.environ["AWS_DEFAULT_REGION"]="us-gov-west-1"
c = boto3.client("sagemaker")
print(c.meta._endpoint_url)

outputs the following:

https://api-fips.sagemaker.us-gov-west-1.amazonaws.com

Possible Solution

I have found an instance of the incorrect url https://github.com/boto/botocore/blob/develop/botocore/data/endpoints.json#L21706

Additional Information/Context

No response

SDK version used

1.33.1

Environment details (OS name and version, etc.)

python@3.9.16

@ben-kaiser ben-kaiser added bug This issue is a confirmed bug. needs-triage This issue or PR still needs to be triaged. labels Jan 12, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Jan 18, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added p2 This is a standard priority issue investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 18, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @ben-kaiser, thanks for reaching out. I was able to reproduce this issue. I've reached out to the SageMaker service about this behavior. In the meantime, as this is a service team issue, I've created a tracking issue in our cross-SDK repository (aws/aws-sdk#680). Please refer to this issue for any updates. Thanks!

@RyanFitzSimmonsAK RyanFitzSimmonsAK removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Jan 19, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a confirmed bug. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants