Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature eks credentials #3044

Merged
merged 15 commits into from
Nov 13, 2023
Merged

Conversation

SamRemis
Copy link
Contributor

This PR updates the existing container credential fetcher to support retrieving credentials from EKS

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0c6a76) 93.46% compared to head (89736f6) 93.46%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3044   +/-   ##
========================================
  Coverage    93.46%   93.46%           
========================================
  Files           66       66           
  Lines        14007    14027   +20     
========================================
+ Hits         13091    13111   +20     
  Misses         916      916           
Files Coverage Δ
botocore/credentials.py 98.45% <100.00%> (+0.01%) ⬆️
botocore/utils.py 79.54% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise looks good. Thanks @SamRemis!

botocore/utils.py Outdated Show resolved Hide resolved
@SamRemis SamRemis merged commit 54a09c7 into boto:develop Nov 13, 2023
40 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Nov 14, 2023
* release-1.32.0:
  Bumping version to 1.32.0
  Update to latest partitions and endpoints
  Update to latest models
  Feature eks credentials (#3044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants