resolves issue 3124 #3125
Closed
resolves issue 3124 #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dbrumley, Thank you for the contribution. I just opened up a PR for an experimental opt in header for exactly this; we are hesitant to make this change the default since customers may be relying on the existing behavior which is fully functional for S3. In the future, this may become the default once we are confident that this is not a breaking change. The content-length header is also not guaranteed to be present, so making a best-effort check on the length of the body will work for more use cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3124
We've been maintaining this patch locally in our company for awhile, and just noticed. Figured it's best to get upstream.