chore: Modified bug issue template to add checkbox to report potential regression. #3250
Conversation
| steps: | ||
| - name: Fetch template body | ||
| id: check_regression | ||
| uses: actions/github-script@v7 |
There was a problem hiding this comment.
Let's pin it to the specific release SHA instead of a tag.
| uses: actions/github-script@v7 | |
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea |
There was a problem hiding this comment.
@nateprewitt I guess the commit corresponds to v7.0.1. Should we instead change it to actions/github-script@v7.0.1?
There was a problem hiding this comment.
Both v7 and v7.0.1 are the same commit. This may have been an error on their side.
The issue we're controlling for is supply chain attacks where someone gets access to a repo, deletes an existing tag, and replaces it pointing to another commit. All of our workflows use exact SHAs to prevent this and we should maintain that in any new workflow.
There was a problem hiding this comment.
Looks good, thanks @ashishdhingra! Can we get these changes moved to the boto3/cli versions of these PRs as well?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3250 +/- ##
===========================================
+ Coverage 93.15% 93.17% +0.02%
===========================================
Files 66 66
Lines 14287 14339 +52
===========================================
+ Hits 13309 13361 +52
Misses 978 978 ☔ View full report in Codecov by Sentry. |
@nateprewitt Done for other PR(s) as well:
Please review. Also help them merge since I do not have permissions to do so. Thanks, |
ashishdhingra
deleted the
user/ashdhin/IssueTemplateRegressionCheckbox
branch
potential-regressionwhen issue is created/edited.NOTE:
potential-regressionwould need to be created manually (we could use color#FF6700and descriptionMarking this issue as a potential regression to be checked by team memberto make it consistent across SDK repos)Label
potential-regressionwould make issue standout in the list and help engineers to triage potential high severity issues effectively.