Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zui): preserve descriptions in toTypescriptSchema #547

Merged
merged 13 commits into from
Feb 10, 2025

Conversation

pascal-botpress
Copy link
Member

Addresses CLS-2622

Copy link
Member

@franklevasseur franklevasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Before merging, can you take a look at the tests in zui/src/transforms/zui-to-typescript-schema/index.test.ts and ensure that a few tests ensure that title and descriptions are preserved ?

franklevasseur
franklevasseur previously approved these changes Feb 10, 2025
Copy link
Member

@franklevasseur franklevasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget to bump zui by a patch

@pascal-botpress pascal-botpress merged commit cf9c7f3 into master Feb 10, 2025
1 check passed
@pascal-botpress pascal-botpress deleted the pb/zui-ts-schema branch February 10, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants