-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zui): preserve descriptions in toTypescriptSchema #547
Conversation
cb69405
to
1bc6876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Before merging, can you take a look at the tests in zui/src/transforms/zui-to-typescript-schema/index.test.ts
and ensure that a few tests ensure that title and descriptions are preserved ?
1bc6876
to
38d9c54
Compare
vitest's vi now types the calls[] array properly, which made the mistake evident
611b35b
to
d504ee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont forget to bump zui by a patch
Addresses CLS-2622