simplify build system #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
force-pushed
the
buildsys-bin
branch
2 times, most recently
from
25d4b89
to
25fe41e
Compare
tjkirch
approved these changes
Dec 2, 2019
bcressey
force-pushed
the
buildsys-bin
branch
from
25fe41e
to
2323d9f
Compare
iliana
approved these changes
Dec 3, 2019
Previously, doing a full build that respected the dependency graph would cause almost every package to be rebuilt when the kernel was updated, which happened at regular intervals. The cascade feature was added to allow a developer to opt out of the full dependency tracking in the interests of speeding up iterative builds. However, making use of it required two full builds to get cargo in sync, with no reliable way to predict whether either build would be quick. This limited its usefulness in practice. Now that the kernel is a leaf package, we will only rebuild the world when glibc changes, which we expect to happen less often. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Loading `buildsys` as a library means that we rebuild the world when any of its dependencies change. Calling it as a binary eliminates another source of unwanted rebuilds. Signed-off-by: Ben Cressey <bcressey@amazon.com>
bcressey
force-pushed
the
buildsys-bin
branch
from
2323d9f
to
87c36aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#245
Description of changes:
Remove the "cascade" feature, since it doesn't add as much value now that many of the early dependencies have moved into the SDK. Turn
buildsysinto a binary, to streamline the build process for both packages and images.Testing done:
cargo make worldworks.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.