setup basic familienkarte event collector #116
Draft
+70
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadhonn
reviewed
Oct 14, 2023
|
|
||
|
|
||
| override fun getAllUnparsedEvents(): List<String> { | ||
| val document = Jsoup.parse(fetcher.fetchUrl("https://www.familienkarte.at/de/freizeit/veranstaltungen/veranstaltungskalender.html?events_cat_key=8")) |
There was a problem hiding this comment.
short question about the url. why limit it to events from category 8? also, i saw that by default the page only shows events from today, we should extend that so we get more events from them
kadhonn
reviewed
Oct 14, 2023
| if (endDate != null) { | ||
| data[SemanticKeys.ENDDATE] = endDate.format(DateTimeFormatter.ISO_DATE) | ||
| } | ||
| data[SemanticKeys.TYPE] = "other" |
There was a problem hiding this comment.
type other does not really make sense, if you don't have any information on the type of event just don't add it :)
kadhonn
reviewed
Oct 14, 2023
| val data = mutableMapOf<String, String>() | ||
| data[SemanticKeys.URL] = event | ||
| if (endDate != null) { | ||
| data[SemanticKeys.ENDDATE] = endDate.format(DateTimeFormatter.ISO_DATE) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.