BM-1859: Clean Bento Inputs #1298
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
a team,
Wollac,
austinabell,
capossele,
willemolding and
zeroecco
as code owners
Contributor
|
bento section looks fine to me |
Contributor
|
realizing there is a flaw with this in that currently we cache inputs to try to deduplicate, so deleting one may interfere with another if in-between preflight and prove. Will explore alternatives to see if a clean way to get around |
Contributor
|
Experimented with uploading duplicate input for each order variant, can work but is pretty messy and very unideal to put more memory pressure on the REST API and unnecessary IO. Intuition is that perhaps checking the other variant is skipped/failed/completed before deleting might be a better way around this, with the tradeoff that on the race condition both check at the same time, storage is leaked. Will explore that when I work on this next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes the inputs which can be quite large (e.g. Signal) when the Order is completed or failed.
It will also delete when it fails preflights in the OrderPicker and when the OrderMonitor decides to skip.
Still testing on personal machine to see how effective this is.