Use project slugs instead of IDs in notification links #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification links currently use project IDs (
/projects/{id}), but project routes are slug-based (/projects/[slug]), resulting in broken links.Changes
Type Definition (
types/notifications.ts)projectSlug?: stringto notification data interfaceShared Utility (
lib/notifications.ts)getProjectUrlFromNotification()to centralize URL generation logicComponents Updated
NotificationItem.tsx- Link generation uses shared utilityNotificationDropdown.tsx- Navigation uses shared utilityExample
Backend Requirements
Backend must include
projectSlugin notification payloads:{ "projectId": "123", "projectName": "My Project", "projectSlug": "my-project" }Until backend sends
projectSlug, links will continue usingprojectIdas fallback.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Summary by CodeRabbit
Improvements
Refactor