Update debug and js-beautify dependencies; remove unnecessary use of lodash #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the built-in Array.forEach instead of _.each, and Object.assign instead of _.assign. These were the only things lodash was used for.
Lockfiles shouldn’t exist at all, but most of the harm they do can be mitigated by keeping them as ephemeral as possible. In particular, they should not be committed to version control ever. Discourage this by adding package-lock.json to .gitignore. /En passant/ add leading slashes to several things that should only ever exist at top level.
Despite the major version bump to ‘debug’ (0 -> 4) no code changes are required.
|
updated version of patch avoids using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dependencies on debug and js-beautify to current versions (^4.3.0 and ^1.14.0 respectively).
It also removes the dependency on lodash, which was only being used for things that can be done just as easily with built-in JavaScript functions (Array.forEach, Object.assign). That change was originally written by @khadro (Sitback@632585e), I only cleaned it up a little.
This fixes 2
npm auditcomplaints (debug <2.6.9 [low], lodash <4.17.20 [critical]) and so would close #6. It describes itself as version 0.2.2.