Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge boututils into boutdata #67

Merged
merged 137 commits into from
Jul 30, 2024
Merged

Merge boututils into boutdata #67

merged 137 commits into from
Jul 30, 2024

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Apr 8, 2022

Keeps history from the standalone repo. Also imports the most commonly used bits of boututils into boutdata at the top level.

I haven't made any attempt at cleaning up the repo. Do we want to try and keep the history of boututils from the main BOUT++ repo?

loeiten and others added 30 commits May 24, 2019 08:51
`mayavi` is not required for all the `boututils` to work, so make it an 'extra' requirement.
0.1.2 -> 0.1.3
Make mayavi an optional dependency
Co-authored-by: Michael Løiten <michael.l.magnussen@gmail.com>
dschwoerer and others added 14 commits March 23, 2023 15:20
Fix bug in computation of derivative with DFT
- Use ruff instead of flake8
- Auto-apply black and isort on commits to master
- Bump CI action versions
- Drop support for Python 3.7
- Test on Python 3.8, 3.11
- Don't run cron jobs

Fixes #39
Use PyPA's new "Trusted Publisher" thing:
https://docs.pypi.org/trusted-publishers/

Fixes #49
We now only support Python 3.8+
BOUT++ 4.3.0 was released a while ago
xBOUT depends on this, so I doubt it is going to replace it anytime soon.
Whether it will ever happen is a different story ...
@ZedThree
Copy link
Member Author

I was just about to make an issue about possibly merging these two repos when I found this PR again.

Any objections to me reviving this and pressing ahead?

dschwoerer and others added 10 commits April 30, 2024 09:53
Do not compare types, use `isinstance()`
* master: (59 commits)
  restart.resize: Disable multiprocessing if maxProc=1
  Allow simplified user access via python -m
  Apply black changes
  Fix creating restart files for BOUT++ 5
  restart.create: Remove empty except
  restart.create: Ensure that hist_hi is a scalar
  restart.resize: nz doesn't need to be a power of 2
  Remove unneeded setup.py
  CI: Fix publish workflow
  Remove cron job
  Apply black changes
  Apply black changes
  set _file0 early to avoid error in destructor
  prefer removeprefix
  Bump required python to 3.9
  prefer removesuffix
  Run black
  prefer to not explicitly check for None
  requirements.txt is not used
  CI: Test against py 3.11
  ...
* utils/master: (21 commits)
  black
  Do not compare types, use `isinstance()`
  Update README.md
  Remove imports from `builtin`
  Replace most common uses of string concatenation with f-strings
  Apply black
  Remove fallback backport of importlib.metadata
  CI: Update publishing workflow
  Fix bare `except`
  Refactor CI
  Move to pyproject.toml package config
  black format
  Auto update pre-commit-config
  CI: Update flake8 to github repo
  Add basic xarray support
  Ensure to always write int32
  Fix bug in computation of derivative with DFT
  Do ignore file we shouldn't track
  Move the definition of all bout_types of BoutArray to BoutArray
  Update requirements.txt
  ...
@ZedThree
Copy link
Member Author

Remembered about this PR again. Updated to both package's master, and moved them under src.

I think the separation between the two packages is mostly artificial at this point, and there's a lot of cruft in boututils that is probably not very useful any more. It probably makes sense to have another PR moving all the useful things directly into boutdata, and then re-importing them back into boututils with a deprecation warning or something.

@ZedThree
Copy link
Member Author

I'm going to use admin privileges to merge this and tidy things up a bit in another PR

@ZedThree ZedThree merged commit f9ed3d1 into master Jul 30, 2024
9 checks passed
@ZedThree ZedThree deleted the merge-boututils branch July 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants