dx should be always positive definie

boutproject · Oct 8, 2024 · b5331ed · b5331ed
1 parent 36fb632
commit b5331ed
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/hypnotoad/core/mesh.py b/hypnotoad/core/mesh.py
@@ -839,9 +839,6 @@ def geometry1(self):
         """
         self.psixy = self.meshParent.equilibrium.psi(self.Rxy, self.Zxy)
 
-        self.dx = MultiLocationArray(self.nx, self.ny)
-        self.dx.centre = (self.psi_vals[2::2] - self.psi_vals[:-2:2])[:, numpy.newaxis]
-        self.dx.ylow = (self.psi_vals[2::2] - self.psi_vals[:-2:2])[:, numpy.newaxis]
 
         if self.psi_vals[0] > self.psi_vals[-1]:
             # x-coordinate is -psixy so x always increases radially across grid
@@ -851,6 +848,11 @@ def geometry1(self):
             self.bpsign = 1.0
             self.xcoord = self.psixy
 
+        # dx must be positive definite
+        self.dx = MultiLocationArray(self.nx, self.ny)
+        self.dx.centre = self.bpsign*(self.psi_vals[2::2] - self.psi_vals[:-2:2])[:, numpy.newaxis]
+        self.dx.ylow = self.bpsign*(self.psi_vals[2::2] - self.psi_vals[:-2:2])[:, numpy.newaxis]
+
         self.dy = MultiLocationArray(self.nx, self.ny)
         self.dy.centre = self.meshParent.dy_scalar
         self.dy.ylow = self.meshParent.dy_scalar