Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix download for empty files #1231

Merged
merged 3 commits into from
Feb 2, 2024
Merged

fix: fix download for empty files #1231

merged 3 commits into from
Feb 2, 2024

Conversation

mwwoda
Copy link
Contributor

@mwwoda mwwoda commented Jan 31, 2024 •
edited
Loading

Fixes #1230
Remove unecessary contentLength check for stream response

@coveralls
Copy link

coveralls commented Jan 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3535

  • 0 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 71.47%
Totals Coverage Status
Change from base Build #3528: 0.009%
Covered Lines: 7450
Relevant Lines: 10424
💛 - Coveralls

@mwwoda mwwoda merged commit 0e2230b into main Feb 2, 2024
15 of 18 checks passed
@mwwoda mwwoda deleted the fix-download-for-empty-file branch February 2, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After the version upgrade, I am getting a NullPointerException when trying to read an empty file.
3 participants
@mwwoda @coveralls @lukaszsocha2