Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support create empty shared link #1241

Merged
merged 4 commits into from
Mar 29, 2024
Merged

fix: Support create empty shared link #1241

merged 4 commits into from
Mar 29, 2024

Conversation

congminh1254
Copy link
Member

No description provided.

antusus
antusus previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Pull Request Test Coverage Report for Build #3672

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 71.982%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3654: 0.003%
Covered Lines: 7502
Relevant Lines: 10422
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3681

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 71.988%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3654: 0.009%
Covered Lines: 7504
Relevant Lines: 10424
💛 - Coveralls

antusus
antusus approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@congminh1254 congminh1254 merged commit 0c86487 into main Mar 29, 2024
11 of 12 checks passed
@congminh1254 congminh1254 deleted the fix-create-empty-shared-link branch March 29, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @antusus