Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to modify the underlying client from the connection when using factory method #1272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow to modify the underlying client from the connection when using factory method #1272

wants to merge 1 commit into from

Conversation

davigotxi
Copy link

Refs: #1271

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@davigotxi davigotxi changed the title feat: allow to modify the underlying okHttpClient from the BoxApiConnection subclasses feat: allow to modify the underlying http client from the box api connection subclasses Nov 11, 2024
@davigotxi davigotxi changed the title feat: allow to modify the underlying http client from the box api connection subclasses feat: allow to modify the underlying OkHttpClient from the box api connection subclasses Nov 11, 2024
@davigotxi davigotxi changed the title feat: allow to modify the underlying OkHttpClient from the box api connection subclasses feat: allow to modify the underlying client from the box api connection subclasses Nov 11, 2024
@congminh1254 congminh1254 changed the title feat: allow to modify the underlying client from the box api connection subclasses feat: allow to modify the underlying client from the Box API connection subclasses Nov 12, 2024
@congminh1254
Copy link
Member

Hi @davigotxi

Thanks for your contribution, currently the build is failing, please review the it.

@davigotxi davigotxi force-pushed the 1271-modify-okhttpclientbuilder branch from 3bb5be5 to 8c67b7a Compare November 12, 2024 10:48
@davigotxi
Copy link
Author

davigotxi commented Nov 12, 2024 •
edited
Loading

Hi @davigotxi

Thanks for your contribution, currently the build is failing, please review the it.

Thanks @congminh1254! That should be fixed now

@coveralls
Copy link

Pull Request Test Coverage Report for Build #4076

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.771%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/SharedLinkAPIConnection.java 0 1 0.0%
Totals Coverage Status
Change from base Build #4057: 0.03%
Covered Lines: 8052
Relevant Lines: 11219
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #4080

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 71.738%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/SharedLinkAPIConnection.java 0 1 0.0%
Totals Coverage Status
Change from base Build #4057: 0.001%
Covered Lines: 8054
Relevant Lines: 11227
💛 - Coveralls

@davigotxi davigotxi marked this pull request as draft November 13, 2024 03:30
@davigotxi
feat: allow to modify the underlying okHttpClient from the BoxDevelop…
a84c1cd 
…erEditionAPIConnection when using factory method
@davigotxi davigotxi force-pushed the 1271-modify-okhttpclientbuilder branch from 8c67b7a to a84c1cd Compare November 13, 2024 03:44
@davigotxi davigotxi changed the title feat: allow to modify the underlying client from the Box API connection subclasses feat: allow to modify the underlying okHttpClient from the BoxDeveloperEditionAPIConnection when using factory method Nov 13, 2024
@davigotxi davigotxi marked this pull request as ready for review November 13, 2024 03:46
@davigotxi davigotxi changed the title feat: allow to modify the underlying okHttpClient from the BoxDeveloperEditionAPIConnection when using factory method feat: allow to modify the underlying client from the connection when using factory method Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davigotxi @CLAassistant @congminh1254 @coveralls