-
-
Notifications
You must be signed in to change notification settings - Fork 636
Formula support #612
base: master
Are you sure you want to change the base?
Formula support #612
Conversation
composer.json
Outdated
@@ -1,5 +1,5 @@ | |||
{ | |||
"name": "box/spout", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be changed in your PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as being said I needed this in prod, so I'll commit another with the correct package name
So basically, this sets the formula without calculation it, right? So it wouldn't affect performance (much)? Looks nice. Similar to #425 but this allows to set the pre-calculated value, which is nice :) |
This ia based on that PR but with two changes
|
Should this be targeted at the v3 branch? As that is coming soon(ish) as it seems? |
|
Merged a variation in openspout/openspout#5 |
Hey there,
I always needed the formula in my reports, so I've made an implementation of that, And it would be nice to have it within the original package.
P.S. Really needed that on production ASAP so had to change the composer package, if this causes a problem with the PR, I can fork to different repo
Thanks
Eli