This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add phpstan #830
Open
Add phpstan #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � .travis.yml � CONTRIBUTING.md � composer.json � src/Spout/Common/Entity/Cell.php � tests/Spout/Writer/ODS/WriterTest.php
|
Merged in openspout/openspout#31 and openspout/openspout#32, thank you |
adrilo
reviewed
Mar 21, 2022
| - php: 7.3 | ||
| env: WITH_PHPUNIT=true | ||
| - php: 7.3 | ||
| env: WITH_PHPUNIT=true WITH_COVERAGE=true | ||
| - php: 7.4 | ||
| env: WITH_PHPUNIT=true | ||
| - php: 8.0 |
There was a problem hiding this comment.
why removing PHP 8? I think it's important to keep it
There was a problem hiding this comment.
Note to self: openspout does build on PHP 8.0 https://github.com/openspout/openspout/blob/a9904c716d6b18b8d4198b204ac3256cc9346888/.github/workflows/ci.yml#L67
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added phpstan until level 7 (8 is max level).
I hope is ok for you 🙂