Feature/table cell vertical alignment #2436

Kran67 · 2022-05-17T08:22:08Z

Table cell vertical alignment - for stack, column, list, text, image, qr, svg

… image, canvas, qr, svg

This reverts commit a0781c5.

Kran67 · 2022-05-17T08:27:26Z

Hi,
You can use table cell vertical alignment with one new property 'verticalAlign' (values: 'middle', 'bottom', see example)

…b.com/SirFull/pdfmake into feature/table_cell_vertical_alignment

jbenjoy2 · 2022-06-01T18:56:07Z

@Gheeks @bpampuch if we could get this feature merged and released asap that would be lovely! Thank you

jbenjoy2 · 2022-06-06T17:30:03Z

@Gheeks @bpampuch if we could get this feature merged and released asap that would be lovely! Thank you

@bpampuch definitely need to get this feature released asap so if we could please get this merged and released, we'd all really appreciate it.

SawkaDev · 2022-06-07T14:11:13Z

Agreed. Eager for this feature. Thanks for your work!

maxpropp · 2022-06-10T07:15:29Z

Can't wait for this to be merged

dumbasPL

why do we need all the begin/end - Vertical alignment comments everywhere? Git already shows a nice diff.
Alos why do we need the __ prefix everywhere? Rest of this project seems to use "normal" names.

dumbasPL · 2022-06-09T14:02:34Z

src/LayoutBuilder.js

+		// begin - Vertical alignment
+		const lastNode = this.__nodesHierarchy.pop();
+		lastNode.__contentHeight = Math.max(...columns.map(c => c.__contentHeight));
+		this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


there is a missing check for this.__nodesHierarchy.length > 0

dumbasPL · 2022-06-09T14:04:45Z

src/LayoutBuilder.js

@@ -613,6 +648,10 @@ class LayoutBuilder {
 		this.writer.removeListener('lineAdded', addMarkerToFirstLeaf);

 		this.writer.context().addMargin(-gapSize.width);
+		// begin - Vertical alignment
+		const lastNode = this.__nodesHierarchy.pop();
+		this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


another missing check for this.__nodesHierarchy.length > 0

dumbasPL · 2022-06-10T07:17:01Z

src/TableProcessor.js

+            cellHeight = table.__rowsHeight[rowIndex].height;
+          }
+          if (cellHeight) {
+            const pageItems = writer._context.pages.flatMap(x => x.items);


Note for people porting this to the 0.2 branch: This line needs to be

const pageItems = writer.writer.context.pages.flatMap(x => x.items);

taken from bpampuch/pdfmake#2436

Kran67 · 2022-06-10T07:52:08Z

why do we need all the begin/end - Vertical alignment comments everywhere? Git already shows a nice diff. Alos why do we need the __ prefix everywhere? Rest of this project seems to use "normal" names.

begin/end - Vertical alignment> only for information
Prefix __ is only to avoid future naming conflicts

maxpropp · 2022-06-22T08:19:22Z

are there news regarding this?

SawkaDev · 2022-07-26T15:18:00Z

Any estimate on when this can be merged? I think this feature will greatly improve pdfmake tables!

fe-art · 2022-08-31T09:37:04Z

Guys please, we've been asking for this feature since 2014 ❤️

DanielOfCourse · 2022-09-26T15:50:05Z

It would be so awesome to have this merged in, plsplspls

use paddingTop in processTableVerticalAlignment

maxpropp · 2022-10-26T11:28:24Z

Is there a problem with this PR? So we can update it and finally merge it?

ChrisSimoniMBT · 2022-11-17T15:23:32Z

@Kran67 have you addressed the changes so this can get merged?

ChrisSimoniMBT

Added what I believe are the suggested changes so we can rebase inside github if desired.

ChrisSimoniMBT · 2022-11-17T15:24:45Z

src/LayoutBuilder.js

+		// begin - Vertical alignment
+		const lastNode = this.__nodesHierarchy.pop();
+		lastNode.__contentHeight = Math.max(...columns.map(c => c.__contentHeight));
+		this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


Suggested change

this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;

this.__nodesHierarchy.length > 0 && (this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight);

Suggested check

ChrisSimoniMBT · 2022-11-17T15:25:23Z

src/LayoutBuilder.js

@@ -613,6 +648,10 @@ class LayoutBuilder {
 		this.writer.removeListener('lineAdded', addMarkerToFirstLeaf);

 		this.writer.context().addMargin(-gapSize.width);
+		// begin - Vertical alignment
+		const lastNode = this.__nodesHierarchy.pop();
+		this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


Suggested change

this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;

this.__nodesHierarchy.length > 0 && (this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight);

Suggested check

ChrisSimoniMBT · 2022-11-17T15:29:44Z

@bpampuch @liborm85 Any input on this PR?

nw-onediscovery · 2022-11-29T18:37:20Z

Would love to see this feature merged soon.

anthonygacis · 2023-10-01T03:38:00Z

update pls.

manuelncfa · 2023-11-06T14:57:30Z

I'm in need of this feature, could this be merged and released?

jdwit · 2024-02-09T14:27:28Z

Would be great if this is merged 👍

KostyanWest · 2024-04-01T11:43:49Z

I prefer to install this library from the SirFull's fork rather than wait for this PR to be merged. Fortunately, package managers such as npm can do it directly from github from the specific branch:
npm install SirFull/pdfmake#table_cell_vertical_alignment
or from the specific commit:
npm install SirFull/pdfmake#aec02a68af06c44991ae3dc45bdf443dde570ba4
I'm not sure any update will be as important as this one.

chjiyun · 2024-06-02T11:39:06Z

unable to install

I prefer to install this library from the SirFull's fork rather than wait for this PR to be merged. Fortunately, package managers such as npm can do it directly from github from the specific branch: npm install SirFull/pdfmake#table_cell_vertical_alignment or from the specific commit: npm install SirFull/pdfmake#aec02a68af06c44991ae3dc45bdf443dde570ba4 I'm not sure any update will be as important as this one.

KostyanWest · 2024-06-06T23:29:38Z

unable to install

I prefer to install this library from the SirFull's fork rather than wait for this PR to be merged. Fortunately, package managers such as npm can do it directly from github from the specific branch: npm install SirFull/pdfmake#table_cell_vertical_alignment or from the specific commit: npm install SirFull/pdfmake#aec02a68af06c44991ae3dc45bdf443dde570ba4 I'm not sure any update will be as important as this one.

Sorry, I'm new to the web development and the stuff around it, so I have no idea where the problem is. I installed this library form the specific commit right now (2nd example) and everything seems to be okay. This line
"@sirfull/pdfmake": "github:SirFull/pdfmake#aec02a68af06c44991ae3dc45bdf443dde570ba4",
has also been added to the package.json.

t0m-4 · 2024-09-07T11:58:16Z

Hello, @Kran67 and me are working together, last week i will try to merge last version and ill add recommended suggestions from here.

t0m-4 · 2024-09-09T13:19:20Z

I updated the fork with the latest updates and suggestions.

I also added a way to stretch the table height according to the parent. To do this, you need to set a line height to "*", the generation will then be done twice to know the available height of the parent and modify the line height accordingly.

Miguel LOPES added 3 commits May 17, 2022 10:08

Feat(Table cell vertical alignment) - for text, stack, columns, list,…

0aef943

… image, canvas, qr, svg

Fix: CRLF

a0781c5

Revert "Fix: CRLF"

640a9d1

This reverts commit a0781c5.

sirfullTom and others added 5 commits May 17, 2022 15:44

fix indentation

f528db6

init sfs repo

acdfca7

updated the build

7df5ef2

Fix : function name & lineHeight

5787e4a

Merge branch 'feature/table_cell_vertical_alignment' of https://githu…

ad3e102

…b.com/SirFull/pdfmake into feature/table_cell_vertical_alignment

SawkaDev mentioned this pull request May 18, 2022

Align text in a table column vertically #74

Open

Gheeks approved these changes May 23, 2022

View reviewed changes

dumbasPL suggested changes Jun 10, 2022

View reviewed changes

dumbasPL added a commit to Createch-Corp/pdfmake that referenced this pull request Jun 10, 2022

add Table cell vertical alignment

3dbdf2b

taken from bpampuch/pdfmake#2436

sirfullTom and others added 3 commits October 25, 2022 18:03

use paddingTop in processTableVerticalAlignment

ecba23b

Merge pull request #1 from SirFull/fix/padding-vertical-alignment

0795850

use paddingTop in processTableVerticalAlignment

updated version

a46dee1

ChrisSimoniMBT suggested changes Nov 17, 2022

View reviewed changes

t0m-4 added 6 commits September 6, 2024 16:10

merge

a2c12da

build

859b34d

fix merge

b7f8e5d

fix

2ea57b6

fix eslint

16137d4

fix eslitn verticalAlignment sample

c7d31e6

t0m-4 added 9 commits September 9, 2024 10:27

fix pr comments

6d77717

merge

997703e

reinit package json

b201a40

remove npmrc

15f666a

build & exemples

f215a2a

up with last src repo

f104326

up build & exemples

4b97f4e

publis package yml

9dba972

publish package

d51d9c4

t0m-4 and others added 7 commits September 11, 2024 17:55

stretch working

066d51b

fix

dc43438

working with copy

14de809

stretch heights on table working

de4063b

fix lint

1cb4475

cleaning

3546ce5

cleaning

fe745c1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/table cell vertical alignment #2436

Feature/table cell vertical alignment #2436

Kran67 commented May 17, 2022

Kran67 commented May 17, 2022

jbenjoy2 commented Jun 1, 2022 •

edited

Loading

jbenjoy2 commented Jun 6, 2022

SawkaDev commented Jun 7, 2022

maxpropp commented Jun 10, 2022

dumbasPL left a comment

dumbasPL Jun 9, 2022

dumbasPL Jun 9, 2022

dumbasPL Jun 10, 2022

Kran67 commented Jun 10, 2022

maxpropp commented Jun 22, 2022

SawkaDev commented Jul 26, 2022

fe-art commented Aug 31, 2022

DanielOfCourse commented Sep 26, 2022

maxpropp commented Oct 26, 2022

ChrisSimoniMBT commented Nov 17, 2022

ChrisSimoniMBT left a comment

ChrisSimoniMBT Nov 17, 2022

ChrisSimoniMBT Nov 17, 2022

ChrisSimoniMBT commented Nov 17, 2022

nw-onediscovery commented Nov 29, 2022

anthonygacis commented Oct 1, 2023

manuelncfa commented Nov 6, 2023

jdwit commented Feb 9, 2024

KostyanWest commented Apr 1, 2024

chjiyun commented Jun 2, 2024

KostyanWest commented Jun 6, 2024

t0m-4 commented Sep 7, 2024

t0m-4 commented Sep 9, 2024 •

edited

Loading

	this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;
	this.__nodesHierarchy.length > 0 && (this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight);

Feature/table cell vertical alignment #2436

Are you sure you want to change the base?

Feature/table cell vertical alignment #2436

Conversation

Kran67 commented May 17, 2022

Kran67 commented May 17, 2022

jbenjoy2 commented Jun 1, 2022 • edited Loading

jbenjoy2 commented Jun 6, 2022

SawkaDev commented Jun 7, 2022

maxpropp commented Jun 10, 2022

dumbasPL left a comment

Choose a reason for hiding this comment

dumbasPL Jun 9, 2022

Choose a reason for hiding this comment

dumbasPL Jun 9, 2022

Choose a reason for hiding this comment

dumbasPL Jun 10, 2022

Choose a reason for hiding this comment

Kran67 commented Jun 10, 2022

maxpropp commented Jun 22, 2022

SawkaDev commented Jul 26, 2022

fe-art commented Aug 31, 2022

DanielOfCourse commented Sep 26, 2022

maxpropp commented Oct 26, 2022

ChrisSimoniMBT commented Nov 17, 2022

ChrisSimoniMBT left a comment

Choose a reason for hiding this comment

ChrisSimoniMBT Nov 17, 2022

Choose a reason for hiding this comment

ChrisSimoniMBT Nov 17, 2022

Choose a reason for hiding this comment

ChrisSimoniMBT commented Nov 17, 2022

nw-onediscovery commented Nov 29, 2022

anthonygacis commented Oct 1, 2023

manuelncfa commented Nov 6, 2023

jdwit commented Feb 9, 2024

KostyanWest commented Apr 1, 2024

chjiyun commented Jun 2, 2024

KostyanWest commented Jun 6, 2024

t0m-4 commented Sep 7, 2024

t0m-4 commented Sep 9, 2024 • edited Loading

jbenjoy2 commented Jun 1, 2022 •

edited

Loading

t0m-4 commented Sep 9, 2024 •

edited

Loading