Fixes issues 928 2121 2720 921\n\nFixes issue 2799\n\nFixes PR 2778 #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #928 #2121 #2720 and #921. There was a problem with how page breaks provoked by cells with rowspan were handled.
Fixes issue: #2799: It was trying to find if previous cell started a row span without taking into consideration that column index was increased by col span cells. Method call has been moved before column index has been increased by col span cells
Also fixes PR #2771: The idea to implement the issue was correct, the implementation was not because some wrong assumptions were made. The 'y' variable was not being calculated correctly in all cases.