update Readme and fix couple of spilling errors #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherif1234
force-pushed
the
update-readme
branch
2 times, most recently
from
9341b6c
to
62ff6b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
===========================================
- Coverage 43.82% 26.38% -17.44%
===========================================
Files 18 75 +57
Lines 1716 5021 +3305
===========================================
+ Hits 752 1325 +573
- Misses 846 3532 +2686
- Partials 118 164 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
msherif1234
force-pushed
the
update-readme
branch
from
62ff6b3
to
c9417de
Compare
astoycos
reviewed
Jun 3, 2024
README.md
Outdated
| []() | ||
| [](https://goreportcard.com/report/github.com/bpfman/bpfman-operator) | ||
|
|
||
| ## Deploy bpfman Operation |
There was a problem hiding this comment.
Suggested change
| ## Deploy bpfman Operation | |
| ## Deploy bpfman Operator |
README.md
Outdated
| make run-on-kind | ||
| ``` | ||
|
|
||
| >> **NOTE:** By default, bpfman-operator deploys bpfman with CSI enabled. |
There was a problem hiding this comment.
Suggested change
| >> **NOTE:** By default, bpfman-operator deploys bpfman with CSI enabled. | |
| > **NOTE:** By default, bpfman-operator deploys bpfman with CSI enabled. |
README.md
Outdated
| make deploy-openshift | ||
| ``` | ||
|
|
||
| To clean up at a later, run: |
There was a problem hiding this comment.
Suggested change
| To clean up at a later, run: | |
| To clean up at a later time, run: |
README.md
Outdated
Comment on lines
63
to
67
| First set up the namespace and certificates for the operator with: | ||
|
|
||
| ```bash | ||
| oc apply -f ./hack/ocp-scc-hacks.yaml | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| First set up the namespace and certificates for the operator with: | |
| ```bash | |
| oc apply -f ./hack/ocp-scc-hacks.yaml | |
| ``` | |
| First create the namespace: | |
| ```bash | |
| oc create ns openshift-bpfman |
README.md
Outdated
| followed by | ||
|
|
||
| ```bash | ||
| oc delete -f ./hack/ocp-scc-hacks.yaml |
There was a problem hiding this comment.
Suggested change
| oc delete -f ./hack/ocp-scc-hacks.yaml | |
| oc delete ns openshift-bpfman |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
msherif1234
force-pushed
the
update-readme
branch
from
c9417de
to
fc6669a
Compare
msherif1234
added a commit
to msherif1234/bpfman-operator
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update readme and fix typos to imporve go report card