Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kind and ocp deploy and run on targets #20

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix kind and ocp deploy and run on targets #20

merged 2 commits into from
Jun 6, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jun 5, 2024 •
edited
Loading

  • fix deploy and run-on-kind targets
  • allow to run make commands on MacOS BSD env
  • add bundle check PR workflow job

Example:

BPFMAN_AGENT_IMG=quay.io/mmahmoud/bpfman-agent:pr-1150  BPFMAN_OPERATOR_IMG=quay.io/mmahmoud/bpfman-operator:pr-1150 make build-images

BPFMAN_AGENT_IMG=quay.io/mmahmoud/bpfman-agent:pr-1150  BPFMAN_OPERATOR_IMG=quay.io/mmahmoud/bpfman-operator:pr-1150 make run-on-kind 

oc get pods -n bpfman
NAME                               READY   STATUS    RESTARTS   AGE
bpfman-daemon-hdzqg                3/3     Running   0          9m29s
bpfman-operator-55d6cb6c57-fzw4f   2/2     Running   0          9m32s

@msherif1234 msherif1234 requested a review from Billy99 June 5, 2024 21:04
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.36%. Comparing base (691a9cd) to head (1861e30).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   26.36%   26.36%           
=======================================
  Files          75       75           
  Lines        5112     5112           
=======================================
  Hits         1348     1348           
  Misses       3600     3600           
  Partials      164      164
Flag Coverage Δ
unittests 26.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234 msherif1234 added bug Something isn't working labels Jun 5, 2024
Billy99
Billy99 reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Billy99 Billy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this build on the MAC? If so that is great. I never tried.

.gitignore Outdated Show resolved Hide resolved
bundle/manifests/bpfman-operator.clusterserviceversion.yaml Outdated
@@ -215,7 +215,7 @@ metadata:
]
capabilities: Basic Install
containerImage: quay.io/bpfman/bpfman-operator:v0.0.0
createdAt: "2024-06-04T18:15:26Z"
createdAt: "2024-06-05T21:00:08Z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just drop this change, meaningless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped

bundle/manifests/bpfman-config_v1_configmap.yaml
@@ -12,4 +12,6 @@ data:
millisec_delay = 10000
kind: ConfigMap
metadata:
annotations: {}
labels: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these added?

Copy link
Contributor Author

@msherif1234 msherif1234 Jun 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change as well as TS change was side effect of make bundle we will need it to pass the new GH action to make sure bundle manifest is updated

@msherif1234
Copy link
Contributor Author

So does this build on the MAC? If so that is great. I never tried.

this solves sed issue I don't have mac to see know for sure if that is it or there more issues, but if anyone has mac just install gsed and we should be good to go

@msherif1234
fix kind and ocp deploy and run on targets
512ed2a 
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@msherif1234 msherif1234 requested a review from Billy99 June 6, 2024 01:50
@msherif1234 msherif1234 force-pushed the fix_kind_deploy branch 3 times, most recently from 5b93fd8 to cea1fb2 Compare June 6, 2024 02:13
@msherif1234
Add bundle check to PR workflow
1861e30 
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
Billy99
Billy99 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Billy99 Billy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Thanks

@mergify mergify bot merged commit b86d220 into bpfman:main Jun 6, 2024
9 checks passed
msherif1234 added a commit to msherif1234/bpfman-operator that referenced this pull request Oct 11, 2024
@msherif1234
Merge pull request bpfman#20 from openshift/appstudio-ocp-bpfman-oper…
ffce2f2 
…ator-bundle

Red Hat Konflux update ocp-bpfman-operator-bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Billy99 Billy99 Billy99 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msherif1234 @Billy99